Skip to content

fix: initial stuck client if root_url is wrong - #30913

Merged
ggazzo merged 6 commits into
developfrom
fix/maybe-initial-stuck-client
Dec 8, 2023
Merged

fix: initial stuck client if root_url is wrong#30913
ggazzo merged 6 commits into
developfrom
fix/maybe-initial-stuck-client

Conversation

@debdutdeb

@debdutdeb debdutdeb commented Nov 9, 2023 •
edited by geekgonecrazy
Loading

Copy link
Copy Markdown
Member

closes #30990
closes #30931
closes #31169

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@debdutdeb
debdutdeb requested a review from a team as a code owner November 9, 2023 19:53
@changeset-bot

changeset-bot Bot commented Nov 9, 2023 •
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: a55c36f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov

codecov Bot commented Nov 9, 2023 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #30913 (a55c36f) into develop (a271587) will decrease coverage by 8.90%.
The diff coverage is 75.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #30913      +/-   ##
===========================================
- Coverage    57.77%   48.88%   -8.90%     
===========================================
  Files          885     3272    +2387     
  Lines        20228    80283   +60055     
  Branches      3766    16318   +12552     
===========================================
+ Hits         11687    39246   +27559     
- Misses        7848    36422   +28574     
- Partials       693     4615    +3922
Flag Coverage Δ
e2e 51.35% <ø> (+8.98%) ⬆️
e2e-api 40.72% <75.00%> (?)
unit 77.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

debdutdeb
debdutdeb commented Nov 10, 2023
View reviewed changes
Comment thread apps/meteor/server/startup/initialData.js Outdated
geekgonecrazy
geekgonecrazy previously approved these changes Nov 24, 2023
View reviewed changes

@geekgonecrazy geekgonecrazy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is extremely disruptive to brand new deployments.

Our 1-click installation images are all affected by this. Because you can't access them with your browser at localhost but Rocket.Chat by default has localhost on root_url and site url

So they'll access at the public ip and it's broken. Very bad first impression

@debdutdeb
debdutdeb requested review from a team as code owners November 24, 2023 20:36
Base automatically changed from release-6.5.0 to master December 1, 2023 17:21
@geekgonecrazy
geekgonecrazy changed the base branch from master to develop December 7, 2023 03:02
@geekgonecrazy geekgonecrazy mentioned this pull request Dec 7, 2023
Closed
@ggazzo
ggazzo merged commit 79029f0 into develop Dec 8, 2023
@ggazzo
ggazzo deleted the fix/maybe-initial-stuck-client branch December 8, 2023 23:22
@ggazzo ggazzo added this to the 6.5.1 milestone Dec 8, 2023
ggazzo pushed a commit that referenced this pull request Dec 11, 2023
@debdutdeb @ggazzo
fix: initial stuck client if root_url is wrong (#30913)
55c95e4
@HassbergKliniken

HassbergKliniken commented Dec 12, 2023

Copy link
Copy Markdown

Hello,

I still have the 3 dots after the update.

It's a clean environment. I tested a lot with the ROOT_URL variable and also tested in MongoDB with the SITE_URL for examble:

mongosh
use rocketchat
db.rocketchat_settings.update({"_id" : "Site_Url"},{$set:{value:"<http://chat2:3000>"}})

I can rotate it however I want, the 3 dots remain.

Another idea what I can test?

@rodrigok rodrigok modified the milestones: 6.5.1, 6.6 Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KevLehman KevLehman KevLehman approved these changes
+1 more reviewer
@geekgonecrazy geekgonecrazy geekgonecrazy left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

6.6

Development

Successfully merging this pull request may close these issues.

Rocket Chat no Termina de Cargar RocketChat 6.4.x fails to load 3 dots when trying to login - relating to SiteURL - and wrong Node.JS version

6 participants

@debdutdeb @HassbergKliniken @geekgonecrazy @KevLehman @rodrigok @ggazzo